Github user tillrohrmann commented on the issue:

    https://github.com/apache/flink/pull/3726
  
    @zhangminglei please refrain from pulling more and more people into the 
loop by directly referencing them given that this is a trivial change and that 
5 people are already involved.
    
    Looking at the `YarnFlinkApplicationMasterRunner` I think it could benefit 
from some more refactoring. For example, I don't think that we need to have an 
`AbstractYarnFlinkApplicationMasterRunner` base class. Both can be combined in 
one class. Then we can instantiate the services and runtime components in the 
constructor of `YarnFlinkApplicationMasterRunner`. That way we can get rid of 
the lock in the `run` method.
    
    Given that, I'm not sure whether this PR makes then sense anymore. I think 
we can close it.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to