Github user fhueske commented on the issue:
https://github.com/apache/flink/pull/3735
Hi @shaoxuan-wang, thanks for the PR. The changes look good.
I opened a PR against your PR branch and refactored the
`CodeGenerator.generateAggregations() method a bit. Among other things, I added
code-gen for grouping sets.
Let me know what you think.
Best, Fabian
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
