[
https://issues.apache.org/jira/browse/FLINK-6242?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15976603#comment-15976603
]
ASF GitHub Bot commented on FLINK-6242:
---------------------------------------
Github user fhueske commented on the issue:
https://github.com/apache/flink/pull/3735
Hi @shaoxuan-wang, thanks for the PR. The changes look good.
I opened a PR against your PR branch and refactored the
`CodeGenerator.generateAggregations() method a bit. Among other things, I added
code-gen for grouping sets.
Let me know what you think.
Best, Fabian
> codeGen DataSet Goupingwindow Aggregates
> ----------------------------------------
>
> Key: FLINK-6242
> URL: https://issues.apache.org/jira/browse/FLINK-6242
> Project: Flink
> Issue Type: Sub-task
> Components: Table API & SQL
> Reporter: Shaoxuan Wang
> Assignee: Shaoxuan Wang
>
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
