[ https://issues.apache.org/jira/browse/FLINK-6351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15978412#comment-15978412 ]
Till Rohrmann commented on FLINK-6351: -------------------------------------- Looks good to me. > Refactoring YarnFlinkApplicationMasterRunner by combining > AbstractYarnFlinkApplicationMasterRunner in one class > --------------------------------------------------------------------------------------------------------------- > > Key: FLINK-6351 > URL: https://issues.apache.org/jira/browse/FLINK-6351 > Project: Flink > Issue Type: Improvement > Components: YARN > Reporter: mingleizhang > Assignee: mingleizhang > > The currently YarnFlinkApplicationMasterRunner inherits from > AbstractYarnFlinkApplicationMasterRunner and seems a bit unnecessary. We > could conbine two classes and then instantiate the services and runtime > components in the constructor of YarnFlinkApplicationMasterRunner for geting > rid of the lock in run method. -- This message was sent by Atlassian JIRA (v6.3.15#6346)