Github user StephanEwen commented on the issue:

    https://github.com/apache/flink/pull/3692
  
    Looks good to me. Thanks @EronWright for also checking this out...
    
    Only minor request I have would be to use something like 
`MesosConfigOptions` to store the config keys. We are trying to move away from 
the pure String based config constants. Have a look at the `YarnConfigOptions` 
for an example.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to