[
https://issues.apache.org/jira/browse/FLINK-5974?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15978462#comment-15978462
]
ASF GitHub Bot commented on FLINK-5974:
---------------------------------------
Github user StephanEwen commented on the issue:
https://github.com/apache/flink/pull/3692
Looks good to me. Thanks @EronWright for also checking this out...
Only minor request I have would be to use something like
`MesosConfigOptions` to store the config keys. We are trying to move away from
the pure String based config constants. Have a look at the `YarnConfigOptions`
for an example.
> Support Mesos DNS
> -----------------
>
> Key: FLINK-5974
> URL: https://issues.apache.org/jira/browse/FLINK-5974
> Project: Flink
> Issue Type: Improvement
> Components: Cluster Management, Mesos
> Reporter: Eron Wright
> Assignee: Vijay Srinivasaraghavan
>
> In certain Mesos/DCOS environments, the slave hostnames aren't resolvable.
> For this and other reasons, Mesos DNS names would ideally be used for
> communication within the Flink cluster, not the hostname discovered via
> `InetAddress.getLocalHost`.
> Some parts of Flink are already configurable in this respect, notably
> `jobmanager.rpc.address`. However, the Mesos AppMaster doesn't use that
> setting for everything (e.g. artifact server), it uses the hostname.
> Similarly, the `taskmanager.hostname` setting isn't used in Mesos deployment
> mode. To effectively use Mesos DNS, the TM should use
> `<task-name>.<framework-name>.mesos` as its hostname. This could be derived
> from an interpolated configuration string.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
