Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/3732#discussion_r112693618
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/nodes/datastream/DataStreamOverAggregate.scala
---
@@ -91,6 +93,22 @@ class DataStreamOverAggregate(
val overWindow: org.apache.calcite.rel.core.Window.Group =
logicWindow.groups.get(0)
+ val distinctVarMap: Map[String,Boolean] = new HashMap[String, Boolean]
--- End diff --
I would do the extraction in the DataStreamOverAggregateRule. There we have
proper access to the input `Calc` and the `RexProgram`. Extraction the function
call as a String is quite fragile. The calc could for instance contain an
attribute called "DISTRIBUTION".
The rule would remove unnest the expression from the `DIST()` RexNode and
remove `DIST`. The distinct information would need to be added to the
DataStreamOverAggregate.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
