[
https://issues.apache.org/jira/browse/FLINK-6250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15978892#comment-15978892
]
ASF GitHub Bot commented on FLINK-6250:
---------------------------------------
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/3732#discussion_r112693618
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/nodes/datastream/DataStreamOverAggregate.scala
---
@@ -91,6 +93,22 @@ class DataStreamOverAggregate(
val overWindow: org.apache.calcite.rel.core.Window.Group =
logicWindow.groups.get(0)
+ val distinctVarMap: Map[String,Boolean] = new HashMap[String, Boolean]
--- End diff --
I would do the extraction in the DataStreamOverAggregateRule. There we have
proper access to the input `Calc` and the `RexProgram`. Extraction the function
call as a String is quite fragile. The calc could for instance contain an
attribute called "DISTRIBUTION".
The rule would remove unnest the expression from the `DIST()` RexNode and
remove `DIST`. The distinct information would need to be added to the
DataStreamOverAggregate.
> Distinct procTime with Rows boundaries
> --------------------------------------
>
> Key: FLINK-6250
> URL: https://issues.apache.org/jira/browse/FLINK-6250
> Project: Flink
> Issue Type: Sub-task
> Components: Table API & SQL
> Reporter: radu
> Assignee: Stefano Bortoli
>
> Support proctime with rows boundaries
> Q1.1. `SELECT SUM( DISTINCT b) OVER (ORDER BY procTime() ROWS BETWEEN 2
> PRECEDING AND CURRENT ROW) FROM stream1`
> Q1.1. `SELECT COUNT(b), SUM( DISTINCT b) OVER (ORDER BY procTime() ROWS
> BETWEEN 2 PRECEDING AND CURRENT ROW) FROM stream1`
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
