[
https://issues.apache.org/jira/browse/FLINK-6351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15979745#comment-15979745
]
ASF GitHub Bot commented on FLINK-6351:
---------------------------------------
GitHub user zhangminglei opened a pull request:
https://github.com/apache/flink/pull/3755
[FLINK-6351] [YARN] Refactoring YarnFlinkApplicationMasterRunner by c…
…ombining AbstractYarnFlinkApplicationMasterRunner in one class.
Thanks for contributing to Apache Flink. Before you open your pull request,
please take the following check list into consideration.
If your changes take all of the items into account, feel free to open your
pull request. For more information and/or questions please refer to the [How To
Contribute guide](http://flink.apache.org/how-to-contribute.html).
In addition to going through the list, please provide a meaningful
description of your changes.
- [ ] General
- The pull request references the related JIRA issue ("[FLINK-XXX] Jira
title text")
- The pull request addresses only one issue
- Each commit in the PR has a meaningful commit message (including the
JIRA id)
- [ ] Documentation
- Documentation has been added for new functionality
- Old documentation affected by the pull request has been updated
- JavaDoc for public methods has been added
- [ ] Tests & Build
- Functionality added by the pull request is covered by tests
- `mvn clean verify` has been executed successfully locally or a Travis
build has passed
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/zhangminglei/flink flink-6351
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/3755.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3755
----
commit 239993cddc0ddc7ccdc29f4666c946bfdd23ba02
Author: zhangminglei <[email protected]>
Date: 2017-04-22T02:35:46Z
[FLINK-6351] [YARN] Refactoring YarnFlinkApplicationMasterRunner by
combining AbstractYarnFlinkApplicationMasterRunner in one class.
----
> Refactor YarnFlinkApplicationMasterRunner by combining
> AbstractYarnFlinkApplicationMasterRunner in one class
> ------------------------------------------------------------------------------------------------------------
>
> Key: FLINK-6351
> URL: https://issues.apache.org/jira/browse/FLINK-6351
> Project: Flink
> Issue Type: Improvement
> Components: YARN
> Reporter: mingleizhang
> Assignee: mingleizhang
>
> The currently YarnFlinkApplicationMasterRunner inherits from
> AbstractYarnFlinkApplicationMasterRunner and seems a bit unnecessary. We
> could conbine two classes and then instantiate the services and runtime
> components in the constructor of YarnFlinkApplicationMasterRunner for geting
> rid of the lock in run method.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
