Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/3001#discussion_r112802344
--- Diff:
flink-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/internals/KinesisDataFetcher.java
---
@@ -458,7 +458,7 @@ public void advanceLastDiscoveredShardOfStream(String
stream, String shardId) {
* 3. Update the subscribedStreamsToLastDiscoveredShardIds state so
that we won't get shards
* that we have already seen before the next time this function is
called
*/
- private List<KinesisStreamShard> discoverNewShardsToSubscribe() throws
InterruptedException {
+ public List<KinesisStreamShard> discoverNewShardsToSubscribe() throws
InterruptedException {
--- End diff --
We would probably need a big refactor of the Kinesis code to be able to not
expose this method, by separating concerns of partition discovery and record
fetching. The exposure is not nice, but I think we have to do it for now ...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
