[
https://issues.apache.org/jira/browse/FLINK-4821?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15979750#comment-15979750
]
ASF GitHub Bot commented on FLINK-4821:
---------------------------------------
Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/3001#discussion_r112802344
--- Diff:
flink-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/internals/KinesisDataFetcher.java
---
@@ -458,7 +458,7 @@ public void advanceLastDiscoveredShardOfStream(String
stream, String shardId) {
* 3. Update the subscribedStreamsToLastDiscoveredShardIds state so
that we won't get shards
* that we have already seen before the next time this function is
called
*/
- private List<KinesisStreamShard> discoverNewShardsToSubscribe() throws
InterruptedException {
+ public List<KinesisStreamShard> discoverNewShardsToSubscribe() throws
InterruptedException {
--- End diff --
We would probably need a big refactor of the Kinesis code to be able to not
expose this method, by separating concerns of partition discovery and record
fetching. The exposure is not nice, but I think we have to do it for now ...
> Implement rescalable non-partitioned state for Kinesis Connector
> ----------------------------------------------------------------
>
> Key: FLINK-4821
> URL: https://issues.apache.org/jira/browse/FLINK-4821
> Project: Flink
> Issue Type: New Feature
> Components: Kinesis Connector
> Reporter: Tzu-Li (Gordon) Tai
> Assignee: Wei-Che Wei
>
> FLINK-4379 added the rescalable non-partitioned state feature, along with the
> implementation for the Kafka connector.
> The AWS Kinesis connector will benefit from the feature and should implement
> it too. This ticket tracks progress for this.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
