Github user kl0u commented on the issue:

    https://github.com/apache/flink/pull/3758
  
    Hi @zhangminglei, thanks for looking into this! I tend to agree with 
@tillrohrmann that there is not need for locking there, as there is no sharing 
of the data-structure between different threads. The same holds for the lock at 
line 726. So these 2 `synchronized()` clauses could go away.
    
    I will have a more thorough look on the whole locking scheme in the class 
in the following days. But for now I think that this PR could be closed and the 
JIRA could be updated.
    
    What do you think?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to