Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/3733#discussion_r113051216
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/TimeWindowPropertyCollector.scala
---
@@ -19,34 +19,44 @@
package org.apache.flink.table.runtime.aggregate
import org.apache.calcite.runtime.SqlFunctions
+import org.apache.flink.table.runtime.types.CRow
import org.apache.flink.types.Row
import org.apache.flink.util.Collector
/**
* Adds TimeWindow properties to specified fields of a row before it
emits the row to a wrapped
* collector.
*/
-class TimeWindowPropertyCollector(windowStartOffset: Option[Int],
windowEndOffset: Option[Int])
- extends Collector[Row] {
+class TimeWindowPropertyCollector[T](windowStartOffset: Option[Int],
windowEndOffset: Option[Int])
--- End diff --
we can make this an `abstract` class and add to subclasses
`RowTimeWindowPropertyCollector` and `CRowTimeWindowPropertyCollector`.
That would avoid the `if` condition to identify the input type.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
