[
https://issues.apache.org/jira/browse/FLINK-6091?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15981888#comment-15981888
]
ASF GitHub Bot commented on FLINK-6091:
---------------------------------------
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/3733#discussion_r113047960
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/AggregateUtil.scala
---
@@ -61,23 +62,28 @@ object AggregateUtil {
* @param generator code generator instance
* @param namedAggregates List of calls to aggregate functions and
their output field names
* @param inputType Input row type
+ * @param inputTypeInfo Input DataStream row type
+ * @param returnTypeInfo Return DataStream row type
* @param isRowTimeType It is a tag that indicates whether the time
type is rowTimeType
* @param isPartitioned It is a tag that indicate whether the input is
partitioned
* @param isRowsClause It is a tag that indicates whether the OVER
clause is ROWS clause
*/
- private[flink] def createUnboundedOverProcessFunction(
+ private[flink] def createUnboundedOverProcessFunction[T](
generator: CodeGenerator,
namedAggregates: Seq[CalcitePair[AggregateCall, String]],
inputType: RelDataType,
+ inputTypeInfo: TypeInformation[T],
--- End diff --
We don't need these types if we keep the code generation as it is.
> Implement and turn on the retraction for aggregates
> ---------------------------------------------------
>
> Key: FLINK-6091
> URL: https://issues.apache.org/jira/browse/FLINK-6091
> Project: Flink
> Issue Type: Sub-task
> Components: Table API & SQL
> Reporter: Shaoxuan Wang
> Assignee: Hequn Cheng
>
> Implement functions for generating and consuming retract messages for
> different aggregates.
> 1. add delete/add property to Row
> 2. implement functions for generating retract messages for unbounded groupBy
> 3. implement functions for handling retract messages for different aggregates.
> 4. handle retraction messages in CommonCorrelate and CommonCalc (retain
> Delete property).
> Note: Currently, only unbounded groupby generates retraction and it is
> working under unbounded and processing time mode. Hence, retraction is only
> supported for unbounded and processing time aggregations so far. We can add
> more retraction support later.
> supported now: unbounded groupby, unbounded and processing time over window
> unsupported now: group window, event time or bounded over window.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
