[
https://issues.apache.org/jira/browse/FLINK-6373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15982533#comment-15982533
]
ASF GitHub Bot commented on FLINK-6373:
---------------------------------------
Github user fhueske commented on the issue:
https://github.com/apache/flink/pull/3765
Hi @haohui, thanks for the PR! I like the approach of the wrapping distinct
aggregator.
Unfortunately, this approach won't work with the upcoming changes for the
the UDAGG interface. The `AggregateFunction` interface won't define methods to
accumulate, etc. Instead, these methods can be implemented for different types,
will be identified by reflection and called from generated code. We handle
scalar and table functions the same way. See PR #3762 for how the
`AggregateFunction` interface will evolve.
Best, Fabian
> Add runtime support for distinct aggregation over grouped windows
> -----------------------------------------------------------------
>
> Key: FLINK-6373
> URL: https://issues.apache.org/jira/browse/FLINK-6373
> Project: Flink
> Issue Type: Bug
> Reporter: Haohui Mai
> Assignee: Haohui Mai
>
> This is a follow up task for FLINK-6335. FLINK-6335 enables parsing the
> distinct aggregations over grouped windows. This jira tracks the effort of
> adding runtime support for the query.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
