[
https://issues.apache.org/jira/browse/FLINK-6384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15983424#comment-15983424
]
ASF GitHub Bot commented on FLINK-6384:
---------------------------------------
GitHub user tillrohrmann opened a pull request:
https://github.com/apache/flink/pull/3774
[FLINK-6384] [py] Remove python binary check via additional process
The PythonStreamer used to check for the existence of the python binary by
starting a python process. This process was not closed afterwards. This
caused
the PythonPlanBinderTest to fail locally.
I think the check whether a python binary exists is not necessary since the
subsequent python command would fail anyway if there is no binary available
on
the system. The system failure message is that there is no such file or
directory.
This error message should be descriptive enough in order to debug such a
problem.
cc @zentol
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/tillrohrmann/flink fixPythonStreamer
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/3774.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3774
----
commit 746fe59737338c02502443c5c3e88c613d0b92ad
Author: Till Rohrmann <trohrm...@apache.org>
Date: 2017-04-25T18:41:58Z
[FLINK-6384] [py] Remove python binary check via additional process
The PythonStreamer used to check for the existence of the python binary by
starting a python process. This process was not closed afterwards. This
caused
the PythonPlanBinderTest to fail locally.
I think the check whether a python binary exists is not necessary since the
subsequent python command would fail anyway if there is no binary available
on
the system. The system failure message is that there is no such file or
directory.
This error message should be descriptive enough in order to debug such a
problem.
----
> PythonStreamer does not close python processes
> ----------------------------------------------
>
> Key: FLINK-6384
> URL: https://issues.apache.org/jira/browse/FLINK-6384
> Project: Flink
> Issue Type: Bug
> Components: Python API
> Affects Versions: 1.3.0
> Reporter: Till Rohrmann
> Assignee: Till Rohrmann
> Fix For: 1.3.0
>
>
> The {{PythonStreamer}} opens a new process calling the python binary to check
> whether the binary is available. This process won't get closed leading to an
> excessive number of open python processes when running the
> {{PythonPlanBinderTest}}. I'm not entirely sure whether we need this extra
> process, because the actual python call with the python code would also fail
> if there is no python binary available.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
