[
https://issues.apache.org/jira/browse/FLINK-6302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15983506#comment-15983506
]
ASF GitHub Bot commented on FLINK-6302:
---------------------------------------
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/3720#discussion_r113292688
--- Diff: docs/Gemfile.lock ---
@@ -30,18 +30,19 @@ GEM
redcarpet (~> 3.1)
safe_yaml (~> 1.0)
toml (~> 0.1.0)
- jekyll-coffeescript (1.0.1)
+ jekyll-coffeescript (1.0.2)
coffee-script (~> 2.2)
+ coffee-script-source (~> 1.11.1)
jekyll-gist (1.4.0)
- octokit (~> 4.3.0)
+ octokit (~> 4.2)
--- End diff --
There was never an explicit version downgrade in `jekyll-gist`, they always
had the `4.3.0` `octokit` dependency since it was added.
Similarly, since we added the `jekyll-gist`/`octokit` dependency the
version of `octokit` was set to `4.3.0`.
In conclusion, it doesn't appear like it's related to a bug fix. We just
always relied on a higher version than `jekyll-gist` did, and it worked out
fine.
> Documentation build error on ruby 2.4
> -------------------------------------
>
> Key: FLINK-6302
> URL: https://issues.apache.org/jira/browse/FLINK-6302
> Project: Flink
> Issue Type: Bug
> Components: Documentation
> Reporter: Tao Meng
> Assignee: Tao Meng
> Priority: Trivial
>
> {code}
> /usr/local/Cellar/ruby/2.4.1_1/include/ruby-2.4.0/ruby/ruby.h:981:28: note:
> expanded from macro 'RSTRING_LEN'
> RSTRING(str)->as.heap.len)
> ~~~~~~~~~~~~~~~~~~~~~~^~~
> yajl_ext.c:881:22: error: use of undeclared identifier 'rb_cFixnum'
> rb_define_method(rb_cFixnum, "to_json", rb_yajl_json_ext_fixnum_to_json,
> -1);
> ^
> 17 warnings and 1 error generated.
> make: *** [yajl_ext.o] Error 1
> make failed, exit code 2
> {code}
> We should update Gemfile.lock.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)