[ 
https://issues.apache.org/jira/browse/FLINK-5869?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15983516#comment-15983516
 ] 

ASF GitHub Bot commented on FLINK-5869:
---------------------------------------

Github user zentol commented on a diff in the pull request:

    https://github.com/apache/flink/pull/3772#discussion_r113272506
  
    --- Diff: 
flink-core/src/main/java/org/apache/flink/configuration/JobManagerOptions.java 
---
    @@ -72,6 +72,13 @@
                        .defaultValue(16)
                        
.withDeprecatedKeys("job-manager.max-attempts-history-size");
     
    +   /**
    +    * The maximum number of prior execution attempts kept in history.
    +    */
    +   public static final ConfigOption<String> EXECUTION_FAILOVER_STRATEGY =
    +           key("jobmanager.execution.failover-strategy")
    +                   .defaultValue("full");
    --- End diff --
    
    have we ever considered defining a set of valid values directly in the 
config option?


> ExecutionGraph use FailoverCoordinator to manage the failover of execution 
> vertexes
> -----------------------------------------------------------------------------------
>
>                 Key: FLINK-5869
>                 URL: https://issues.apache.org/jira/browse/FLINK-5869
>             Project: Flink
>          Issue Type: Sub-task
>          Components: JobManager
>            Reporter: shuai.xu
>            Assignee: shuai.xu
>
> Execution graph doesn't manage the failover of executions. It only care for 
> the state of the whole job, which is CREATED, RUNNING, FAILED, FINISHED, or 
> SUSPEND. 
> For execution failure, it will notice the FailoverCoordinator to do failover.
> It only record the finished job vertex and changes to FINISHED after all 
> vertexes finished.
> It will change to final fail if restart strategy fail or meet unrecoverable 
> exceptions.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to