Github user zentol commented on a diff in the pull request:

    https://github.com/apache/flink/pull/3775#discussion_r113378988
  
    --- Diff: docs/dev/java8.md ---
    @@ -104,7 +104,7 @@ input.filter(line -> !line.contains("not"))
     Currently, Flink only supports jobs containing Lambda Expressions 
completely if they are **compiled with the Eclipse JDT compiler contained in 
Eclipse Luna 4.4.2 (and above)**.
     
     Only the Eclipse JDT compiler preserves the generic type information 
necessary to use the entire Lambda Expressions feature type-safely.
    -Other compilers such as the OpenJDK's and Oracle JDK's `javac` throw away 
all generic parameters related to Lambda Expressions. This means that types 
such as `Tuple2<String,Integer` or `Collector<String>` declared as a Lambda 
function input or output parameter will be pruned to `Tuple2` or `Collector` in 
the compiled `.class` files, which is too little information for the Flink 
Compiler.
    +Other compilers such as the OpenJDK's and Oracle JDK's `javac` throw away 
all generic parameters related to Lambda Expressions. This means that types 
such as `Tuple2<String,Integer>` or `Collector<String>` declared as a Lambda 
function input or output parameter will be pruned to `Tuple2` or `Collector` in 
the compiled `.class` files, which is too little information for the Flink 
Compiler.
    --- End diff --
    
    could you also add a space after the comma `Tuple2<...>` and lower case 
"Compiler" at the very end?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to