[ 
https://issues.apache.org/jira/browse/FLINK-6386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15984281#comment-15984281
 ] 

ASF GitHub Bot commented on FLINK-6386:
---------------------------------------

Github user zentol commented on a diff in the pull request:

    https://github.com/apache/flink/pull/3775#discussion_r113378988
  
    --- Diff: docs/dev/java8.md ---
    @@ -104,7 +104,7 @@ input.filter(line -> !line.contains("not"))
     Currently, Flink only supports jobs containing Lambda Expressions 
completely if they are **compiled with the Eclipse JDT compiler contained in 
Eclipse Luna 4.4.2 (and above)**.
     
     Only the Eclipse JDT compiler preserves the generic type information 
necessary to use the entire Lambda Expressions feature type-safely.
    -Other compilers such as the OpenJDK's and Oracle JDK's `javac` throw away 
all generic parameters related to Lambda Expressions. This means that types 
such as `Tuple2<String,Integer` or `Collector<String>` declared as a Lambda 
function input or output parameter will be pruned to `Tuple2` or `Collector` in 
the compiled `.class` files, which is too little information for the Flink 
Compiler.
    +Other compilers such as the OpenJDK's and Oracle JDK's `javac` throw away 
all generic parameters related to Lambda Expressions. This means that types 
such as `Tuple2<String,Integer>` or `Collector<String>` declared as a Lambda 
function input or output parameter will be pruned to `Tuple2` or `Collector` in 
the compiled `.class` files, which is too little information for the Flink 
Compiler.
    --- End diff --
    
    could you also add a space after the comma `Tuple2<...>` and lower case 
"Compiler" at the very end?


> Missing bracket in 'Compiler Limitation' section
> ------------------------------------------------
>
>                 Key: FLINK-6386
>                 URL: https://issues.apache.org/jira/browse/FLINK-6386
>             Project: Flink
>          Issue Type: Bug
>          Components: Documentation
>    Affects Versions: 1.2.0
>            Reporter: Bowen Li
>            Assignee: Bowen Li
>            Priority: Trivial
>             Fix For: 1.2.2
>
>
> "This means that types such as `Tuple2<String,Integer` or `Collector<String>` 
> declared as..."
> should be 
> "This means that types such as `Tuple2<String,Integer>` or 
> `Collector<String>` declared as..."



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to