[ 
https://issues.apache.org/jira/browse/FLINK-6013?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15984448#comment-15984448
 ] 

ASF GitHub Bot commented on FLINK-6013:
---------------------------------------

Github user zentol commented on a diff in the pull request:

    https://github.com/apache/flink/pull/3736#discussion_r113405034
  
    --- Diff: flink-metrics/flink-metrics-datadog/pom.xml ---
    @@ -0,0 +1,109 @@
    +<?xml version="1.0" encoding="UTF-8"?>
    +<!--
    +Licensed to the Apache Software Foundation (ASF) under one
    +or more contributor license agreements.  See the NOTICE file
    +distributed with this work for additional information
    +regarding copyright ownership.  The ASF licenses this file
    +to you under the Apache License, Version 2.0 (the
    +"License"); you may not use this file except in compliance
    +with the License.  You may obtain a copy of the License at
    +
    +  http://www.apache.org/licenses/LICENSE-2.0
    +
    +Unless required by applicable law or agreed to in writing,
    +software distributed under the License is distributed on an
    +"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
    +KIND, either express or implied.  See the License for the
    +specific language governing permissions and limitations
    +under the License.
    +-->
    +<project xmlns="http://maven.apache.org/POM/4.0.0";
    +         xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";
    +         xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 
http://maven.apache.org/xsd/maven-4.0.0.xsd";>
    +    <modelVersion>4.0.0</modelVersion>
    +
    +   <parent>
    +           <groupId>org.apache.flink</groupId>
    +           <artifactId>flink-metrics</artifactId>
    +           <version>1.3-SNAPSHOT</version>
    +           <relativePath>..</relativePath>
    +   </parent>
    +
    +   <artifactId>flink-metrics-datadog</artifactId>
    +   <name>flink-metrics-datadog</name>
    +
    +   <dependencies>
    +           <dependency>
    +                   <groupId>org.apache.flink</groupId>
    +                   <artifactId>flink-metrics-core</artifactId>
    +                   <version>${project.version}</version>
    +                   <scope>provided</scope>
    +           </dependency>
    +
    +           <dependency>
    +                   <groupId>com.fasterxml.jackson.core</groupId>
    +                   <artifactId>jackson-databind</artifactId>
    +                   <scope>provided</scope>
    +           </dependency>
    +
    +           <dependency>
    +                   <groupId>com.squareup.okhttp3</groupId>
    +                   <artifactId>okhttp</artifactId>
    +                   <version>3.6.0</version>
    +           </dependency>
    +
    +           <dependency>
    +                   <groupId>com.squareup.okio</groupId>
    +                   <artifactId>okio</artifactId>
    +                   <version>1.11.0</version>
    +           </dependency>
    +
    +
    +           <!-- test dependencies -->
    +
    +           <dependency>
    +                   <groupId>org.apache.flink</groupId>
    +                   <artifactId>flink-runtime_2.10</artifactId>
    +                   <version>${project.version}</version>
    +                   <scope>test</scope>
    +           </dependency>
    +
    +           <dependency>
    +                   <groupId>org.apache.flink</groupId>
    +                   <artifactId>flink-test-utils-junit</artifactId>
    +                   <version>${project.version}</version>
    +                   <scope>test</scope>
    +           </dependency>
    +   </dependencies>
    +
    +   <build>
    +           <plugins>
    +                   <plugin>
    +                           <groupId>org.apache.maven.plugins</groupId>
    +                           <artifactId>maven-shade-plugin</artifactId>
    +                           <executions>
    +                                   <execution>
    +                                           <phase>package</phase>
    +                                           <goals>
    +                                                   <goal>shade</goal>
    +                                           </goals>
    +                                           <configuration>
    +                                                   
<shadedClassifierName>jar-with-dependencies</shadedClassifierName>
    --- End diff --
    
    I would remove this and adjust the `opt.xml` again; this makes it more 
consistent with other shaded jars that we produce.


> Add Datadog HTTP metrics reporter
> ---------------------------------
>
>                 Key: FLINK-6013
>                 URL: https://issues.apache.org/jira/browse/FLINK-6013
>             Project: Flink
>          Issue Type: Improvement
>          Components: Metrics
>    Affects Versions: 1.3.0
>            Reporter: Bowen Li
>            Assignee: Bowen Li
>            Priority: Critical
>             Fix For: 1.3.0
>
>
> We at OfferUp use Datadog a lot for metrics and dashboards, and I believe a 
> lot other companies also do.
> Flink right now only has a StatsD metrics reporter, and users have to set up 
> Datadog Agent in order to receive metrics from StatsD and transport them to 
> Datadog. We don't like this approach.
> We prefer to have a Datadog metrics reporter directly contacting Datadog http 
> endpoint.
> I'll take this ticket myself.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to