[ 
https://issues.apache.org/jira/browse/FLINK-6402?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15986909#comment-15986909
 ] 

Stefan Richter commented on FLINK-6402:
---------------------------------------

I think this lock is not required, because we enforce the invariant in the 
constructor that the the reaper thread is always (visibly) not null and 
immutable as long as any open {{SafetyNetCloseableRegistry}} exists.

> Consider locking REAPER_THREAD_LOCK in SafetyNetCloseableRegistry#doRegister()
> ------------------------------------------------------------------------------
>
>                 Key: FLINK-6402
>                 URL: https://issues.apache.org/jira/browse/FLINK-6402
>             Project: Flink
>          Issue Type: Bug
>            Reporter: Ted Yu
>            Priority: Minor
>
> Here is related code:
> {code}
>     PhantomDelegatingCloseableRef phantomRef = new 
> PhantomDelegatingCloseableRef(
>         wrappingProxyCloseable,
>         this,
>         REAPER_THREAD.referenceQueue);
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to