[
https://issues.apache.org/jira/browse/FLINK-5810?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15989303#comment-15989303
]
Ted Yu commented on FLINK-5810:
-------------------------------
In SlotManager#suspend() :
{code}
+ // stop the timeout checks for the TaskManagers and the
SlotRequests
+ taskManagerTimeoutCheck.cancel(false);
+ slotRequestTimeoutCheck.cancel(false);
+
+ taskManagerTimeoutCheck = null;
+ slotRequestTimeoutCheck = null;
{code}
May I ask why false is passed to cancel() ?
Should we care about the possibility that checker(s) keeps running ?
> Harden SlotManager
> ------------------
>
> Key: FLINK-5810
> URL: https://issues.apache.org/jira/browse/FLINK-5810
> Project: Flink
> Issue Type: Sub-task
> Components: Distributed Coordination
> Affects Versions: 1.3.0
> Reporter: Till Rohrmann
> Assignee: Till Rohrmann
> Fix For: 1.3.0
>
>
> Harden the {{SlotManager}} logic to better cope with lost messages.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
