Github user bowenli86 commented on the issue:
https://github.com/apache/flink/pull/3736
@StephanEwen @zentol I've made the following changes:
1) Datadog (DD) itself has a bug of being unstable when users filter
metrics by 'host' in dashboards if 'host' is sent as tags, details in
[FLINK-6013](https://issues.apache.org/jira/browse/FLINK-6013). Communicated
with DD engineers, they fixed the issue, and now, as advised by them, I'm
making 'host' a separate field in metric serialization. Tested the new approach
successfully, and we are able to filter metrics by 'host' consistently
correctly on DD dashboard.
2) Added more unit tests for the above change. Unit tests cover both cases
when 'host' is present in MetricGroup and when it isn't
3) Found Maven can only recognize and run unit tests when file name ends
with 'Test' rather than 'Tests'. So I renamed my test file to
'DatadogHttpClientTest' from 'DatadogHttpClientTests'
4) Upgraded okhttp and okio to newer versions
5) Found mocking system millisec will impact the new okhttp. So I separated
unit tests to two enclosed test sets in 'DatadogHttpClientTest'
Having successfully tested this across my company in the past couple days,
I'm now pretty confident this is production ready.
I agree on @zentol 's proposal if you guys are currently busy with other
things, as long as we make sure this ends up in 1.3 :) Thanks, guys!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
