Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/3777#discussion_r114015255
--- Diff:
flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/HttpRequestHandler.java
---
@@ -197,17 +197,16 @@ else if (currentDecoder != null && msg instanceof
HttpContent) {
/**
* Record the access log if enable configure of
- * {@link
org.apache.flink.configuration.ConfigConstants#JOB_MANAGER_WEB_ACCESSLOG_ENABLE}.
+ * {@link
org.apache.flink.configuration.JobManagerOptions#JOB_MANAGER_WEB_ACCESSLOG_ENABLE}.
* record format:
* remote_addr - [time_local] "request_method URI protocolVersion"
"http_referer" "http_user_agent"
*/
- private void accesslog(ChannelHandlerContext ctx, HttpRequest req) {
+ private void logAccess(ChannelHandlerContext ctx, HttpRequest req) {
HttpHeaders headers = req.headers();
if (headers != null) {
- String line = ctx.channel().remoteAddress() + " - [" +
new Date() + "] \""
+ LOG.info(ctx.channel().remoteAddress() + " - [" + new
Date() + "] \""
--- End diff --
Please rework this to use placeholders instead.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
