Github user greghogan commented on a diff in the pull request:
https://github.com/apache/flink/pull/3779#discussion_r114030670
--- Diff:
flink-libraries/flink-gelly-examples/src/test/java/org/apache/flink/graph/drivers/DriverBaseITCase.java
---
@@ -41,17 +43,41 @@
@Rule
public ExpectedException expectedException = ExpectedException.none();
- protected DriverBaseITCase(TestExecutionMode mode) {
+ protected final String idType;
+
+ protected DriverBaseITCase(TestExecutionMode mode, String idType) {
super(mode);
+
+ this.idType = idType;
}
- // extend MultipleProgramsTestBase default to include object reuse mode
- @Parameterized.Parameters(name = "Execution mode = {0}")
+ @Parameterized.Parameters(name = "Execution mode = {0}, ID type = {1}")
public static Collection<Object[]> executionModes() {
- return Arrays.asList(
- new Object[] { TestExecutionMode.CLUSTER },
- new Object[] { TestExecutionMode.CLUSTER_OBJECT_REUSE },
- new Object[] { TestExecutionMode.COLLECTION });
+ List<Object[]> executionModes = new ArrayList<>();
+
+ for (TestExecutionMode executionMode :
TestExecutionMode.values()) {
+ for (String idType : new String[] {"byte",
"nativeByte", "short", "nativeShort", "char", "nativeChar",
+
"integer", "nativeInteger", "long", "nativeLong", "string", "nativeString"}) {
--- End diff --
I've also changed modified the parameters string to print the ID type
before the ExecutionMode.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
