[ 
https://issues.apache.org/jira/browse/FLINK-2007?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14556400#comment-14556400
 ] 

ASF GitHub Bot commented on FLINK-2007:
---------------------------------------

Github user rmetzger commented on a diff in the pull request:

    https://github.com/apache/flink/pull/697#discussion_r30910025
  
    --- Diff: 
flink-staging/flink-streaming/flink-streaming-core/src/main/java/org/apache/flink/streaming/api/windowing/policy/DeltaPolicy.java
 ---
    @@ -131,4 +145,29 @@ public boolean equals(Object other) {
        public String toString() {
                return "DeltaPolicy(" + threshold + ", " + 
deltaFuntion.getClass().getSimpleName() + ")";
        }
    +
    +   private void writeObject(ObjectOutputStream stream) throws IOException{
    +           stream.writeObject(deltaFuntion);
    +           stream.writeObject(windowBuffer);
    +           stream.writeDouble(threshold);
    --- End diff --
    
    as Gyula said, you can use defaultWriteObject here


> Initial data point in Delta function needs to be serializable
> -------------------------------------------------------------
>
>                 Key: FLINK-2007
>                 URL: https://issues.apache.org/jira/browse/FLINK-2007
>             Project: Flink
>          Issue Type: Bug
>          Components: Streaming
>    Affects Versions: 0.9
>            Reporter: Márton Balassi
>            Assignee: Márton Balassi
>              Labels: serialization, windowing
>             Fix For: 0.9
>
>
> Currently we expect the data point passed to the delta function to be 
> serializable, which breaks the serialization assumptions provided in other 
> parts of the code.
> This information should be properly serialized by Flink serializers instead.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to