[
https://issues.apache.org/jira/browse/FLINK-6346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15994638#comment-15994638
]
ASF GitHub Bot commented on FLINK-6346:
---------------------------------------
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/3812
There is no doubt that you **can** modify the commits of an open PR. My
point is that you **shouldn't** because it messes with the review.
This applies to both squashing commits and force pushing in general. The
only exception is when you rebase the PR; but that should only be done if a
rebase actually causes conflicts.
> Migrate from Java serialization for GenericWriteAheadSink's state
> -----------------------------------------------------------------
>
> Key: FLINK-6346
> URL: https://issues.apache.org/jira/browse/FLINK-6346
> Project: Flink
> Issue Type: Sub-task
> Components: Streaming Connectors
> Reporter: Tzu-Li (Gordon) Tai
> Assignee: Fang Yong
>
> See umbrella JIRA FLINK-6343 for details. This subtask tracks the migration
> for {{GenericWriteAheadSink}}.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
