Github user StephanEwen commented on the issue:

    https://github.com/apache/flink/pull/3800
  
    I remember initially this did not work, because the variables where not 
properly resolved.
    It probably works now, because we force the shade plugin to be evaluated in 
each project (via the `force-shading` dependency). The shade plugin has the 
nice side effect of resolving variables.
    
    The thing we should be aware of here is that by going with this change, we 
must keep the `force-shading` hack. In some sense this PR brings the 
"force-shading" approach to conclusion.
    
    I remember that there was an alternate suggestion initially to not do the 
force-shading and rather have a more elaborate `change-scala-version.sh` script 
instead. 
    Just bringing this up so we are aware of the context/implications. I am 
okay with either approach.
    
    @rmetzger What is you take here?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to