Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/3791#discussion_r114590134
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/table.scala
---
@@ -93,6 +103,11 @@ class Table(
* }}}
*/
def select(fields: Expression*): Table = {
+ if (UserDefinedFunctionUtils.verifyTableFunctionCallExistence(this)) {
--- End diff --
I think we can add these checks without touching all methods of `Table`.
We could implement a method that recursively traverses a `LogicalNode` and
checks if one of this children is an unbounded table function call. This check
is performed in the constructor of Table and throws an exception except, the
`logicalNode` itself is a `LogicalTableFunctionCall` (this is the case if it
was created with the new constructor or `as()` was applied on it.
That way we can remove all checks in the methods.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
