[jira] [Commented] (FLINK-2018) Add ParameterUtil.fromGenericOptionsParser() for compatibility to Hadoop's argument parser

[ASF GitHub Bot (JIRA)]

    [ 
https://issues.apache.org/jira/browse/FLINK-2018?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14558188#comment-14558188
 ] 

ASF GitHub Bot commented on FLINK-2018:
---------------------------------------

Github user rmetzger commented on a diff in the pull request:

    https://github.com/apache/flink/pull/720#discussion_r30977489
  
    --- Diff: 
flink-java/src/test/java/org/apache/flink/api/java/utils/ParameterToolTest.java 
---
    @@ -150,6 +150,14 @@ public void testMerged() {
                validate(parameter);
        }
     
    +   @Test
    +   public void testFromGenericOptionsParser() throws IOException {
    +           System.setProperty("input", "myInput");
    +           System.setProperty("expectedCount", "15");
    +           ParameterTool parameter = 
ParameterTool.fromGenericOptionsParser(new String[]{"-D", "input=myInput", 
"-DexpectedCount=15"});
    --- End diff --
    
    Then why are you setting the two system properties?


> Add ParameterUtil.fromGenericOptionsParser() for compatibility to Hadoop's 
> argument parser
> ------------------------------------------------------------------------------------------
>
>                 Key: FLINK-2018
>                 URL: https://issues.apache.org/jira/browse/FLINK-2018
>             Project: Flink
>          Issue Type: Improvement
>            Reporter: Robert Metzger
>            Priority: Minor
>              Labels: starter
>
> In FLINK-1525 we've added the {{ParameterTool}}.
> For users used to Hadoop's {{GenericOptionsParser}} it would be great to 
> provide a compatible parser.
> See: 
> https://hadoop.apache.org/docs/r1.0.4/api/org/apache/hadoop/util/GenericOptionsParser.html
> {code}
> @Test
> public void testFromGenericOptionsParser() {
>       ParameterUtil parameter = ParameterUtil.fromGenericOptionsParser(new 
> String[]{"-D", "input=myinput", "-DexpectedCount=15"});
>       validate(parameter);
> } 
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)