[
https://issues.apache.org/jira/browse/FLINK-5884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15997628#comment-15997628
]
ASF GitHub Bot commented on FLINK-5884:
---------------------------------------
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/3808#discussion_r114904879
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/sources/DefinedTimeAttributes.scala
---
@@ -0,0 +1,47 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.table.sources
+
+import org.apache.flink.api.java.tuple.Tuple2
+
+/**
+ * Defines logical time attributes for a [[TableSource]]. Time attributes
can be used for
+ * indicating, accessing, and working with Flink's event-time or
processing-time. A
+ * [[TableSource]] that implements this interface can define names and
positions of rowtime
+ * and proctime attributes in the rows it produces.
+ */
+trait DefinedTimeAttributes {
+
+ /**
+ * Defines a name and position (starting at 0) of rowtime attribute
that represents Flink's
+ * event-time. Null if no rowtime should be available. If the position
is within the arity of
+ * the result row, the logical attribute will overwrite the physical
attribute. If the position
+ * is higher than the result row, the time attribute will be appended
logically.
+ */
+ def getRowtimeAttribute: Tuple2[Int, String]
--- End diff --
I don't think we need to offer the option to override the an attribute for
TableSources. They can modify the schema themselves and return the data without
the actual time attribute.
So `getRowtimeAttribute` would just define the name of the logical
attribute.
Same for proctime.
> Integrate time indicators for Table API & SQL
> ---------------------------------------------
>
> Key: FLINK-5884
> URL: https://issues.apache.org/jira/browse/FLINK-5884
> Project: Flink
> Issue Type: New Feature
> Components: Table API & SQL
> Reporter: Timo Walther
> Assignee: Timo Walther
> Priority: Blocker
> Fix For: 1.3.0
>
>
> We already discussed the need for a proper integration of time indicators
> (event-time or processing-time) for both the Table API & SQL on the ML:
> http://apache-flink-mailing-list-archive.1008284.n3.nabble.com/DISCUSS-Table-API-SQL-indicators-for-event-and-processing-time-tp15927.html
> This issue will track the progress. I will work on a design document how we
> can solve this issue.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
