[
https://issues.apache.org/jira/browse/FLINK-6221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15999494#comment-15999494
]
ASF GitHub Bot commented on FLINK-6221:
---------------------------------------
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/3833
I've glanced over this for now but it looks pretty good.
If possible though i would like to not use the DropwizardExports class, for
2 reasons:
1) We now introduce this odd pattern of extending
`ScheduledDropwizardReporter` without actually being scheduled nor creating an
actual Dropwizard reporter.
2) I've looked into the source code and it has the typical Dropwizard
reporter problem where absolutely nothing gets cached and effectively constant
objects are re-created again and again. We can make this way more efficient.
> Add Promethus support to metrics
> --------------------------------
>
> Key: FLINK-6221
> URL: https://issues.apache.org/jira/browse/FLINK-6221
> Project: Flink
> Issue Type: Improvement
> Components: Metrics
> Affects Versions: 1.2.0
> Reporter: Joshua Griffith
> Assignee: Maximilian Bode
> Priority: Minor
>
> [Prometheus|https://prometheus.io/] is becoming popular for metrics and
> alerting. It's possible to use
> [statsd-exporter|https://github.com/prometheus/statsd_exporter] to load Flink
> metrics into Prometheus but it would be far easier if Flink supported
> Promethus as a metrics reporter. A [dropwizard
> client|https://github.com/prometheus/client_java/tree/master/simpleclient_dropwizard]
> exists that could be integrated into the existing metrics system.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
