[
https://issues.apache.org/jira/browse/FLINK-6397?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16000236#comment-16000236
]
ASF GitHub Bot commented on FLINK-6397:
---------------------------------------
Github user ifndef-SleePy commented on a diff in the pull request:
https://github.com/apache/flink/pull/3810#discussion_r115170542
--- Diff:
flink-test-utils-parent/flink-test-utils/src/main/java/org/apache/flink/test/util/MultipleProgramsTestBase.java
---
@@ -80,29 +80,36 @@
protected final TestExecutionMode mode;
-
+ private TestEnvironment testEnvironment;
+
+ private CollectionTestEnvironment collectionTestEnvironment;
+
public MultipleProgramsTestBase(TestExecutionMode mode) {
this.mode = mode;
-
+
switch(mode){
case CLUSTER:
- new TestEnvironment(cluster, 4).setAsContext();
+ testEnvironment = new TestEnvironment(cluster,
4);
--- End diff --
Thank you for responding. Last my comment is not correct. Actually what I
want to say is that we can not move these code to \@BeforeClass and
\@AfterClass. But we can move them to \@Before and \@After, however it will
bring a little overhead since \@Before and \@After will be called for each test
method. I pushed a new commit using \@Before and \@After.
> MultipleProgramsTestBase does not reset ContextEnvironment
> ----------------------------------------------------------
>
> Key: FLINK-6397
> URL: https://issues.apache.org/jira/browse/FLINK-6397
> Project: Flink
> Issue Type: Bug
> Components: Tests
> Affects Versions: 1.3.0
> Reporter: Chesnay Schepler
> Assignee: Biao Liu
>
> The MultipleProgramsTestBase sets a new TestEnvironment as a context
> environment but never explicitly unsets it, which can result subsequent tests
> categorically failing.
> The CustomDistributionITCase doesn't unset the context either; and some
> streaming test that i haven't quite nailed down yet.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
