Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/718#discussion_r31016976
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/memory/MemoryManagerLazyAllocationTest.java
---
@@ -0,0 +1,209 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.runtime.memory;
+
+import org.apache.flink.core.memory.MemorySegment;
+import org.apache.flink.runtime.jobgraph.tasks.AbstractInvokable;
+import org.apache.flink.runtime.memorymanager.DefaultMemoryManager;
+import org.apache.flink.runtime.memorymanager.MemoryAllocationException;
+import org.junit.After;
+import org.junit.Assert;
+import org.junit.Before;
+import org.junit.Test;
+
+import java.util.ArrayList;
+import java.util.List;
+import java.util.Random;
+
+import static org.junit.Assert.fail;
+
+/**
+ * Tests for the memory manager, in the mode where it pre-allocates all
memory.
+ */
+public class MemoryManagerLazyAllocationTest {
+
+ private static final long RANDOM_SEED = 643196033469871L;
+
+ private static final int MEMORY_SIZE = 1024 * 1024 * 72; // 72 MiBytes
+
+ private static final int PAGE_SIZE = 1024 * 32; // 32 KiBytes
+
+ private static final int NUM_PAGES = MEMORY_SIZE / PAGE_SIZE;
+
+ private DefaultMemoryManager memoryManager;
+
+ private Random random;
+
+
+ @Before
+ public void setUp() {
+ this.memoryManager = new DefaultMemoryManager(MEMORY_SIZE, 1,
PAGE_SIZE, false);
+ this.random = new Random(RANDOM_SEED);
+ }
+
+ @After
+ public void tearDown() {
+ if (!this.memoryManager.verifyEmpty()) {
+ fail("Memory manager is not complete empty and valid at
the end of the test.");
+ }
+ this.memoryManager = null;
+ this.random = null;
+ }
+
+ @Test
+ public void allocateAllSingle() {
+ try {
+ final AbstractInvokable mockInvoke = new
DummyInvokable();
+ List<MemorySegment> segments = new
ArrayList<MemorySegment>();
+
+ try {
+ for (int i = 0; i < NUM_PAGES; i++) {
+
segments.add(this.memoryManager.allocatePages(mockInvoke, 1).get(0));
+ }
+ }
+ catch (MemoryAllocationException e) {
+ fail("Unable to allocate memory");
+ }
+
+ for (MemorySegment seg : segments) {
+ this.memoryManager.release(seg);
+ }
+ }
+ catch (Exception e) {
+ e.printStackTrace();
+ fail(e.getMessage());
+ }
+ }
+
+ @Test
+ public void allocateAllMulti() {
+ try {
+ final AbstractInvokable mockInvoke = new
DummyInvokable();
+ final List<MemorySegment> segments = new
ArrayList<MemorySegment>();
+
+ try {
+ for(int i = 0; i < NUM_PAGES / 2; i++) {
+
segments.addAll(this.memoryManager.allocatePages(mockInvoke, 2));
+ }
+ } catch (MemoryAllocationException e) {
+ Assert.fail("Unable to allocate memory");
+ }
+
+ this.memoryManager.release(segments);
+ }
+ catch (Exception e) {
+ e.printStackTrace();
+ fail(e.getMessage());
+ }
+ }
+
+ @Test
+ public void allocateMultipleOwners() {
+ final int NUM_OWNERS = 17;
+
+ try {
+ AbstractInvokable[] owners = new
AbstractInvokable[NUM_OWNERS];
+
+ @SuppressWarnings("unchecked")
+ List<MemorySegment>[] mems = (List<MemorySegment>[])
new List<?>[NUM_OWNERS];
+
+ for (int i = 0; i < NUM_OWNERS; i++) {
+ owners[i] = new DummyInvokable();
+ mems[i] = new ArrayList<MemorySegment>(64);
+ }
+
+ // allocate all memory to the different owners
+ for (int i = 0; i < NUM_PAGES; i++) {
+ final int owner =
this.random.nextInt(NUM_OWNERS);
+
mems[owner].addAll(this.memoryManager.allocatePages(owners[owner], 1));
+ }
+
+ // free one owner at a time
+ for (int i = 0; i < NUM_OWNERS; i++) {
+ this.memoryManager.releaseAll(owners[i]);
+ owners[i] = null;
+ Assert.assertTrue("Released memory segments
have not been destroyed.", allMemorySegmentsFreed(mems[i]));
+ mems[i] = null;
+
+ // check that the owner owners were not affected
+ for (int k = i+1; k < NUM_OWNERS; k++) {
+ Assert.assertTrue("Non-released memory
segments are accidentaly destroyed.", allMemorySegmentsValid(mems[k]));
+ }
+ }
+ }
+ catch (Exception e) {
+ e.printStackTrace();
+ fail(e.getMessage());
+ }
+ }
+
+ @Test
+ public void allocateTooMuch() {
+ try {
+ final AbstractInvokable mockInvoke = new
DummyInvokable();
+
+ List<MemorySegment> segs =
this.memoryManager.allocatePages(mockInvoke, NUM_PAGES);
+
+ try {
+ this.memoryManager.allocatePages(mockInvoke, 1);
+ Assert.fail("Expected
MemoryAllocationException.");
+ } catch (MemoryAllocationException maex) {
+ // expected
+ }
+
+ Assert.assertTrue("The previously allocated segments
were not valid any more.",
+
allMemorySegmentsValid(segs));
+
--- End diff --
Formatting
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
