[
https://issues.apache.org/jira/browse/FLINK-4766?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16001161#comment-16001161
]
ASF GitHub Bot commented on FLINK-4766:
---------------------------------------
GitHub user zentol opened a pull request:
https://github.com/apache/flink/pull/3848
[FLINK-4766] Port TM config parameters to Config Options
This PR ports most taskmanager related config parameters to config options.
The following keys were not ported as i wasn't sure whether they should
really belong to the TaskManagerOptions.
```
DEFAULT_SPILLING_MAX_FAN_KEY = "taskmanager.runtime.max-fan";
DEFAULT_SORT_SPILLING_THRESHOLD_KEY =
"taskmanager.runtime.sort-spilling-threshold";
RUNTIME_HASH_JOIN_BLOOM_FILTERS_KEY =
"taskmanager.runtime.hashjoin-bloom-filters";
FS_STREAM_OPENING_TIMEOUT_KEY = "taskmanager.runtime.fs_timeout";
```
The PR contains 1 commit for each ported parameter.
The majority of changes are straight-forward.
Special attention should be given to `MAX_REGISTRATION_DURATION` in the
`YarnResourceManager`.
The existing code parsed a timeunit String (i.e. "5 ms") directly as an
integer via `Configuration#getInteger()`. This didn't make any sense to me, so
i changed it to first create a `Duration`, convert it to seconds, and then
create a `FiniteDuration` from it.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/zentol/flink 4766_config_tm
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/3848.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3848
----
commit 8ea32ee73d181987e73251668bbb2f61a2976b69
Author: zentol <[email protected]>
Date: 2017-05-08T16:05:53Z
TaskManagerOptions#HOST_NAME
commit 7b7b6116f9445adb33a319a7140f09bfc0dce1d8
Author: zentol <[email protected]>
Date: 2017-05-08T16:11:45Z
TaskManagerOptions#PORT
commit c2f328a928840cf14a03e1d4c07a65702f60adae
Author: zentol <[email protected]>
Date: 2017-05-08T16:23:29Z
TaskManagerOptions#DATA_PORT
commit affb127c3a18b3331cef3842ae128b9b9c3be6c6
Author: zentol <[email protected]>
Date: 2017-05-08T16:33:11Z
TaskManagerOptions#TMP_DIR
commit dcfc91b86de259c158699c535313a9719036c8f9
Author: zentol <[email protected]>
Date: 2017-05-08T16:36:26Z
TaskManagerOptions#LOG_PATH
commit f2a1fe9588ab4ff8cb2b5698177ba1b3ea9838b8
Author: zentol <[email protected]>
Date: 2017-05-08T16:40:28Z
TaskManagerOptions#DATA_SSL_ENABLED
commit 5daa11286cdaf1c0506fc2eefb5d72fc1a0181c6
Author: zentol <[email protected]>
Date: 2017-05-08T16:43:38Z
TaskManagerOptions#NETWORK_IO_MODE
commit 99a817c0ce19bb3b8da1325444a1769c43f58ba2
Author: zentol <[email protected]>
Date: 2017-05-08T17:01:20Z
TaskManagerOptions#NUM_TASK_SLOTS
commit f33d1411175d098a829223dca09d6d86e788ac81
Author: zentol <[email protected]>
Date: 2017-05-08T17:04:22Z
TaskManagerOptions#DEBUG_MEMORY_USAGE_LOG_THREAD
commit 8a14b275a015782fbed5a84d94fd01acd51788c8
Author: zentol <[email protected]>
Date: 2017-05-08T17:07:16Z
TaskManagerOptions#DEBUG_MEMORY_USAGE_LOG_INTERVAL_MS
commit f514a365d56d53989d2e387ebc2eb83794e6c836
Author: zentol <[email protected]>
Date: 2017-05-08T17:15:42Z
TaskManagerOptions#MAX_REGISTRATION_DURATION
commit 232e3f38714653bbc9f92275a502bad699cc6c5d
Author: zentol <[email protected]>
Date: 2017-05-08T17:19:21Z
TaskManagerOptions#INITIAL_REGISTRATION_PAUSE
commit 9917546d2367d79fd2ce3742269b4083f7e3e2c1
Author: zentol <[email protected]>
Date: 2017-05-08T17:21:17Z
TaskManagerOptions#MAX_REGISTRATION_PAUSE
commit 2640e2de50d4ba4f1e96286c0f9755f138e02bde
Author: zentol <[email protected]>
Date: 2017-05-08T17:23:27Z
TaskManagerOptions#REFUSED_REGISTRATION_PAUSE
----
> Migrate TaskManager configuration options
> -----------------------------------------
>
> Key: FLINK-4766
> URL: https://issues.apache.org/jira/browse/FLINK-4766
> Project: Flink
> Issue Type: Sub-task
> Components: Distributed Coordination
> Reporter: Stephan Ewen
> Assignee: Chesnay Schepler
>
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
