[
https://issues.apache.org/jira/browse/FLINK-6509?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16002511#comment-16002511
]
ASF GitHub Bot commented on FLINK-6509:
---------------------------------------
GitHub user tillrohrmann opened a pull request:
https://github.com/apache/flink/pull/3853
[FLINK-6509] [tests] Perform TestingListener#waitForNewLeader under lock
Performin TestingListener#waitForNewLeader under the lock which is also
hold when
updating the leader information makes sure that leader changes won't go
unnoticed.
This led before to failing test cases due to timeouts.
cc @StefanRRichter.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/tillrohrmann/flink fixTestingListener
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/3853.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3853
----
commit 2e36adb971d20892e179a4980ee1fc2ec2133e7b
Author: Till Rohrmann <[email protected]>
Date: 2017-05-09T11:13:02Z
[FLINK-6509] [tests] Perform TestingListener#waitForNewLeader under lock
Performin TestingListener#waitForNewLeader under the lock which is also
hold when
updating the leader information makes sure that leader changes won't go
unnoticed.
This led before to failing test cases due to timeouts.
----
> TestingListener might miss JobLeader notifications
> --------------------------------------------------
>
> Key: FLINK-6509
> URL: https://issues.apache.org/jira/browse/FLINK-6509
> Project: Flink
> Issue Type: Bug
> Components: Tests
> Affects Versions: 1.3.0
> Reporter: Till Rohrmann
> Assignee: Till Rohrmann
> Fix For: 1.3.0
>
>
> The {{TestingListener}} might miss JobLeader notifications because it does
> not perform the check under the lock. This should be changed.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
