[ 
https://issues.apache.org/jira/browse/FLINK-6426?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16002572#comment-16002572
 ] 

ASF GitHub Bot commented on FLINK-6426:
---------------------------------------

Github user fhueske commented on the issue:

    https://github.com/apache/flink/pull/3806
  
    Hi @sunjincheng121, thanks for the PR. 
    I would like to keep the term `Group Window` and think that 
`WindowWithoutAlias` might be confusing. So, I'd rather keep the docs as they 
are. We will need to go over this anyways when we add Over windows and 
non-windowed aggregates. 
    
    What do you think?
    Thanks, Fabian


> Update the document of group-window table API&SQL
> -------------------------------------------------
>
>                 Key: FLINK-6426
>                 URL: https://issues.apache.org/jira/browse/FLINK-6426
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Documentation, Table API & SQL
>    Affects Versions: 1.3.0
>            Reporter: sunjincheng
>            Assignee: sunjincheng
>
> 1.Correct the method parameter type error in the group-window table API 
> document, change the document from ` .window([w: Window] as 'w)` to ` 
> .window([w: WindowWithoutAlias] as 'w)`
> 2. For the consistency of tableAPI and SQL, change the description of SQL 
> document from "Group Windows" to "Windows".



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to