Github user greghogan commented on a diff in the pull request:

    https://github.com/apache/flink/pull/3858#discussion_r115541319
  
    --- Diff: docs/dev/best_practices.md ---
    @@ -31,13 +31,13 @@ This page contains a collection of best practices for 
Flink programmers on how t
     ## Parsing command line arguments and passing them around in your Flink 
application
     
     
    -Almost all Flink applications, both batch and streaming rely on external 
configuration parameters.
    -For example for specifying input and output sources (like paths or 
addresses), also system parameters (parallelism, runtime configuration) and 
application specific parameters (often used within the user functions).
    +Almost all Flink applications, both batch and streaming, rely on external 
configuration parameters.
    +For example, they are used to specify input and output sources (like paths 
or addresses), system parameters (parallelism, runtime configuration), and 
application specific parameters (typically used within user functions).
    --- End diff --
    
    Do we need to say "for example"?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to