[
https://issues.apache.org/jira/browse/FLINK-6504?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16004495#comment-16004495
]
ASF GitHub Bot commented on FLINK-6504:
---------------------------------------
Github user StefanRRichter commented on a diff in the pull request:
https://github.com/apache/flink/pull/3859#discussion_r115714053
--- Diff:
flink-contrib/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/RocksDBKeyedStateBackend.java
---
@@ -911,9 +915,11 @@ void releaseResources(boolean canceled) {
if (canceled) {
List<StateObject> statesToDiscard = new
ArrayList<>();
--- End diff --
We could also preallocate the size of `statesToDiscard` as the sum all
things we are planning to insert in the next step.
> Lack of synchronization on materializedSstFiles in RocksDBKEyedStateBackend
> ---------------------------------------------------------------------------
>
> Key: FLINK-6504
> URL: https://issues.apache.org/jira/browse/FLINK-6504
> Project: Flink
> Issue Type: Bug
> Components: State Backends, Checkpointing
> Affects Versions: 1.3.0
> Reporter: Stefan Richter
> Assignee: Xiaogang Shi
>
> Concurrent checkpoints could access `materializedSstFiles` in the
> `RocksDBStateBackend` concurrently. This should be avoided.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
