[ 
https://issues.apache.org/jira/browse/FLINK-6330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16004756#comment-16004756
 ] 

ASF GitHub Bot commented on FLINK-6330:
---------------------------------------

Github user patricklucas commented on a diff in the pull request:

    https://github.com/apache/flink/pull/3751#discussion_r115753699
  
    --- Diff: docs/page/css/syntax.css ---
    @@ -77,3 +77,6 @@
     .highlight .vg { color: #008080 } /* Name.Variable.Global */
     .highlight .vi { color: #008080 } /* Name.Variable.Instance */
     .highlight .il { color: #009999 } /* Literal.Number.Integer.Long */
    +
    +/* Missing YAML styles */
    +.highlight .l-Scalar-Plain { color: #008080 }
    --- End diff --
    
    Yeah, the highlighter we use doesn't have any built-in styling for YAML. I 
had to search around quite a bit for context and came up mostly dry.
    
    Moreover, the actual tokenizer it uses only emits two token types, 
l-Scalar-Plain and p-Indicator. (You can see this in action by inspecting the 
HTML 
[here](https://ci.apache.org/projects/flink/flink-docs-release-1.2/monitoring/metrics.html#jmx-orgapacheflinkmetricsjmxjmxreporter))
    
    This change applies the color I found most applicable from the existing 
highlighting rules and applies it to l-Scalar-Plain to make it at least 
slightly more interesting than black-on-white.


> Improve Docker documentation
> ----------------------------
>
>                 Key: FLINK-6330
>                 URL: https://issues.apache.org/jira/browse/FLINK-6330
>             Project: Flink
>          Issue Type: Bug
>          Components: Docker
>    Affects Versions: 1.2.0
>            Reporter: Patrick Lucas
>            Assignee: Patrick Lucas
>             Fix For: 1.2.2
>
>
> The "Docker" page in the docs exists but is blank.
> Add something useful here, including references to the official images that 
> should exist once 1.2.1 is released, and add a brief "Kubernetes" page as 
> well, referencing the [helm chart|https://github.com/docker-flink/examples]. 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to