[ 
https://issues.apache.org/jira/browse/FLINK-6508?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16004821#comment-16004821
 ] 

ASF GitHub Bot commented on FLINK-6508:
---------------------------------------

Github user StephanEwen commented on the issue:

    https://github.com/apache/flink/pull/3852
  
    @fhueske I worked on getting the ASM license in all shaded JAR files. That 
change would subsume this one. Can you have a look what you think?
    
    BTW: I could not use the shade resource transformer for the ASM license, 
because of the way that maven/shade handles relative paths and due to the fact 
that the resource transformer fails when a dependency already brings the same 
file.
    
    Lesson learned today: It sounds simple to add a specific file in various 
projects to a JAR. But to do that with Maven (in a project like Flink) can take 
the better part of a day ;-)


> Include license files of packaged dependencies
> ----------------------------------------------
>
>                 Key: FLINK-6508
>                 URL: https://issues.apache.org/jira/browse/FLINK-6508
>             Project: Flink
>          Issue Type: Bug
>          Components: Table API & SQL
>    Affects Versions: 1.3.0, 1.2.1, 1.4.0
>            Reporter: Fabian Hueske
>            Assignee: Fabian Hueske
>            Priority: Blocker
>
> The Maven artifact for flink-table bundles its (non-Flink) dependencies to 
> have a self-contained JAR file that can be moved to the ./lib folder without 
> adding additional dependencies.
> Currently, we include Apache Calcite, Guava (relocates and required by 
> Calcite), Janino, and Reflections.
> Janino and Reflections are not under Apache license, so we need to include 
> their license files into the JAR file.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to