[ 
https://issues.apache.org/jira/browse/FLINK-2090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14559083#comment-14559083
 ] 

Stephan Ewen commented on FLINK-2090:
-------------------------------------

How about we print at most N (= 3 or 10) elements. After each element, we check 
whether the string buffer has more than 100 characters. If yes, we abort there.

> toString of CollectionInputFormat takes long time when the collection is huge
> -----------------------------------------------------------------------------
>
>                 Key: FLINK-2090
>                 URL: https://issues.apache.org/jira/browse/FLINK-2090
>             Project: Flink
>          Issue Type: Improvement
>            Reporter: Till Rohrmann
>            Priority: Minor
>
> The {{toString}} method of {{CollectionInputFormat}} calls {{toString}} on 
> its underlying {{Collection}}. Thus, {{toString}} is called for each element 
> of the collection. If the {{Collection}} contains many elements or the 
> individual {{toString}} calls for each element take a long time, then the 
> string generation can take a considerable amount of time. [~mikiobraun] 
> noticed that when he inserted several jBLAS matrices into Flink.
> The {{toString}} method is mainly used for logging statements in 
> {{DataSourceNode}}'s {{computeOperatorSpecificDefaultEstimates}} method and 
> in {{JobGraphGenerator.getDescriptionForUserCode}}. I'm wondering whether it 
> is necessary to print the complete content of the underlying {{Collection}} 
> or if it's not enough to print only the first 3 elements in the {{toString}} 
> method.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to