Github user sunjincheng121 commented on the issue:
https://github.com/apache/flink/pull/3863
Hi @fhueske thanks a lot for your reviewing. I had update the PR. with
following changes:
* Uniform hump name, change all `qConfig` and `qConf` to `queryConfig`.
* Add warn log into `DataStreamOverAggregate`.
* Fix cleanup logic
* Extend test cases that cover the corner cases of the clean up logic.
But there are two things I have not do, that is:
* `check for processing time over range windows that
minIdleStateRetentionTime > preceding interval.`
I do not think we need add this check. Because both row-base and
time-base will be able to meet the incorrect result due to state cleanup. an
importation thing we need to do is let use know the function of the cleanup
config.
* `remove the registerEventCleanupTimer method`
The reason of I add this method is In A row-time OVER
(TimeDomain.EVENT_TIME), we always get 0 when we call
ctx.timerService.currentProcessingTime.
What do you think?
Thanks,
SunJincheng
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
