[ 
https://issues.apache.org/jira/browse/FLINK-6225?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16007125#comment-16007125
 ] 

ASF GitHub Bot commented on FLINK-6225:
---------------------------------------

Github user haohui commented on a diff in the pull request:

    https://github.com/apache/flink/pull/3748#discussion_r116092436
  
    --- Diff: 
flink-connectors/flink-connector-cassandra/src/test/java/org/apache/flink/streaming/connectors/cassandra/CassandraConnectorITCase.java
 ---
    @@ -438,6 +462,45 @@ public void cancel() {
        }
     
        @Test
    +   public void testCassandraTableSink() throws Exception {
    +           StreamExecutionEnvironment env = 
StreamExecutionEnvironment.getExecutionEnvironment();
    +           env.setParallelism(1);
    +
    +           DataStreamSource<Row> source = 
env.fromCollection(rowCollection);
    +           CassandraTableSink cassandraTableSink = new 
CassandraTableSink(new ClusterBuilder() {
    +                   @Override
    +                   protected Cluster buildCluster(Cluster.Builder builder) 
{
    +                           return builder.addContactPointsWithPorts(new 
InetSocketAddress(HOST, PORT)).build();
    +                   }
    +           }, INSERT_DATA_QUERY, new Properties());
    +           CassandraTableSink newCassandrTableSink = 
cassandraTableSink.configure(FIELD_NAMES, FIELD_TYPES);
    +
    +           newCassandrTableSink.emitDataStream(source);
    +
    +           env.execute();
    +           ResultSet rs = session.execute(SELECT_DATA_QUERY);
    +           Assert.assertEquals(20, rs.all().size());
    +   }
    +
    +   @Test
    +   public void testCassandraTableSinkE2E() throws Exception {
    +           StreamExecutionEnvironment env = 
StreamExecutionEnvironment.getExecutionEnvironment();
    +           env.setParallelism(4);
    +           StreamTableEnvironment tEnv = 
StreamTableEnvironment.getTableEnvironment(env);
    --- End diff --
    
    Agree. I think you're right. @PangZhi can you please make the suggested 
changes?


> Support Row Stream for CassandraSink
> ------------------------------------
>
>                 Key: FLINK-6225
>                 URL: https://issues.apache.org/jira/browse/FLINK-6225
>             Project: Flink
>          Issue Type: New Feature
>          Components: Cassandra Connector
>    Affects Versions: 1.3.0
>            Reporter: Jing Fan
>            Assignee: Haohui Mai
>             Fix For: 1.3.0
>
>
> Currently in CassandraSink, specifying query is not supported for row-stream. 
> The solution should be similar to CassandraTupleSink.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to