[
https://issues.apache.org/jira/browse/FLINK-6457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16007513#comment-16007513
]
ASF GitHub Bot commented on FLINK-6457:
---------------------------------------
GitHub user Xpray opened a pull request:
https://github.com/apache/flink/pull/3880
[FLINK-6457] Clean up ScalarFunction and TableFunction interface
Thanks for contributing to Apache Flink. Before you open your pull request,
please take the following check list into consideration.
If your changes take all of the items into account, feel free to open your
pull request. For more information and/or questions please refer to the [How To
Contribute guide](http://flink.apache.org/how-to-contribute.html).
In addition to going through the list, please provide a meaningful
description of your changes.
- [x] General
- The pull request references the related JIRA issue ("[FLINK-XXX] Jira
title text")
- The pull request addresses only one issue
- Each commit in the PR has a meaningful commit message (including the
JIRA id)
- [ ] Documentation
- Documentation has been added for new functionality
- Old documentation affected by the pull request has been updated
- JavaDoc for public methods has been added
- [x] Tests & Build
- Functionality added by the pull request is covered by tests
- `mvn clean verify` has been executed successfully locally or a Travis
build has passed
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/Xpray/flink FLINK-6457
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/3880.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3880
----
commit c55d582227820110f7967ff8b39625deb2530f4d
Author: Xpray <leonxp...@gmail.com>
Date: 2017-05-11T15:59:39Z
[FLINK-6457] Clean up ScalarFunction and TableFunction interface
----
> Clean up ScalarFunction and TableFunction interface
> ---------------------------------------------------
>
> Key: FLINK-6457
> URL: https://issues.apache.org/jira/browse/FLINK-6457
> Project: Flink
> Issue Type: Improvement
> Components: Table API & SQL
> Reporter: Ruidong Li
> Assignee: Ruidong Li
>
> Motivation:
> Some methods in ScalarFunction and TableFunction are unnecessary, e.g
> toString() and getResultType in ScalarFunction
> this issue intend to clear the interface.
> Goal:
> only methods related to `Collector` will remain in TableFunction interface,
> and ScalarFunction interface shall have no methods , user can choose whether
> to implement the `getResultType` method, which will be called by reflection,
> and the Flink document will have instructions for user.
> Future:
> There should be some Annotations for user to implement methods like `@Eval`
> for eval method, it be will in the next issue
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
