Github user shixiaogang commented on a diff in the pull request:
https://github.com/apache/flink/pull/3859#discussion_r116148624
--- Diff:
flink-contrib/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/RocksDBKeyedStateBackend.java
---
@@ -911,9 +915,11 @@ void releaseResources(boolean canceled) {
if (canceled) {
List<StateObject> statesToDiscard = new
ArrayList<>();
- statesToDiscard.add(metaStateHandle);
- statesToDiscard.addAll(miscFiles.values());
- statesToDiscard.addAll(newSstFiles.values());
+ synchronized (this) {
--- End diff --
Yes, i agree. The key point here is to make sure the stopping of the
materialization thread. Synchronization does little help here. So i prefer to
remove synchronization here, what do you think?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
