Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/3881#discussion_r116207779
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/zookeeper/ZooKeeperStateHandleStore.java
---
@@ -346,17 +346,20 @@ public int exists(String pathInZooKeeper) throws
Exception {
} else {
// Initial cVersion (number of changes to the
children of this node)
int initialCVersion = stat.getCversion();
-
- List<String> children =
ZKPaths.getSortedChildren(
-
client.getZookeeperClient().getZooKeeper(),
-
ZKPaths.fixForNamespace(client.getNamespace(), "/"));
-
- for (String path : children) {
- path = "/" + path;
+ List<String> childrenInStr =
+
client.getZookeeperClient().getZooKeeper().
+
getChildren(ZKPaths.fixForNamespace(client.getNamespace(), "/"), false);
+ List<Long> children = new
ArrayList<Long>(childrenInStr.size());
+ for(String childNode : childrenInStr) {
+ children.add(new Long(childNode));
+ }
--- End diff --
Where are the children sorted? Again, I think this only works because
`ZooKeeper#getChildren` returns the nodes in the right order in the test case.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
