[
https://issues.apache.org/jira/browse/FLINK-6566?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16008030#comment-16008030
]
ASF GitHub Bot commented on FLINK-6566:
---------------------------------------
GitHub user tzulitai opened a pull request:
https://github.com/apache/flink/pull/3883
[FLINK-6566] [core] More restricted interface for
VersionedIOReadableWritable hooks
This PR makes the method hooks for defining compatible
serialization versions of `VersionedIOReadableWritable`s more restricted.
Functionally everything remains the same, but with lesser space for
error-prone user implementations. It also allows for a better error
message to indicate version mismatch.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/tzulitai/flink FLINK-6566
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/3883.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3883
----
commit ac35ce3632ae9b3f15b5eafe9df99c399e5bde5d
Author: Tzu-Li (Gordon) Tai <[email protected]>
Date: 2017-05-12T12:06:01Z
[FLINK-6566] [core] More restricted interface for
VersionedIOReadableWritable hooks
This commit makes the method hooks for defining compatibile
serialization versions of VersionedIOReadableWritables more restricted.
Functionally everything remains the same, but with lesser space for
error-prone user implementations. It also allows for a better error
message to indicate version mismatch.
----
> Narrow down interface for compatibility hook method in
> VersionedIOReadableWritable
> ----------------------------------------------------------------------------------
>
> Key: FLINK-6566
> URL: https://issues.apache.org/jira/browse/FLINK-6566
> Project: Flink
> Issue Type: Improvement
> Components: Core, Type Serialization System
> Affects Versions: 1.3.0
> Reporter: Tzu-Li (Gordon) Tai
>
> The {{VersionedIOReadableWritable}} provides a {{isCompatibleVersion}} method
> that allows users to override to resolve older versions.
> This method allows too much space for the user to mess up the implementation,
> and is much more relevant now because we have an user-facing class
> {{TypeSerializerConfigSnapshot}} which extends
> {{VersionedIOReadableWritable}}.
> Instead of a {{isCompatibleVersion}} method, it should only expose a narrower
> {{int[] getCompatibleVersions}} that the internal version check uses.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
