[
https://issues.apache.org/jira/browse/FLINK-6284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16008095#comment-16008095
]
ASF GitHub Bot commented on FLINK-6284:
---------------------------------------
Github user ramkrish86 commented on the issue:
https://github.com/apache/flink/pull/3881
@tillrohrmann
Thanks for the new PR. I just executed your change with 101, 99 , 100 as
the checkpoint order. In this case 100 should be the latest one though the
actual ids are not sorted. But with your change and my earlier commit it will
always sort 99, 100, 101.
Can you take a look at my latest commit, that is based on czxid (as per
your suggestion) and I think that makes sense. What ever be the actual id, in
the zookeeper what was created recently will be the latest checkpoint. But am
not very sure if the checkpointId will really be added in a non-sorted way and
can 100 be the latest one (though 101 was also there).
> Incorrect sorting of completed checkpoints in
> ZooKeeperCompletedCheckpointStore
> -------------------------------------------------------------------------------
>
> Key: FLINK-6284
> URL: https://issues.apache.org/jira/browse/FLINK-6284
> Project: Flink
> Issue Type: Bug
> Components: State Backends, Checkpointing
> Reporter: Xiaogang Shi
> Priority: Blocker
> Fix For: 1.3.0
>
>
> Now all completed checkpoints are sorted in their paths when they are
> recovered in {{ZooKeeperCompletedCheckpointStore}} . In the cases where the
> latest checkpoint's id is not the largest in lexical order (e.g., "100" is
> smaller than "99" in lexical order), Flink will not recover from the latest
> completed checkpoint.
> The problem can be easily observed by setting the checkpoint ids in
> {{ZooKeeperCompletedCheckpointStoreITCase#testRecover()}} to be 99, 100 and
> 101.
> To fix the problem, we should explicitly sort found checkpoints in their
> checkpoint ids, without the usage of
> {{ZooKeeperStateHandleStore#getAllSortedByName()}}
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
